The power of refactoring?

Submitted by Priyank on Thu, 24/12/2009 - 01:59
Printer-friendly versionPDF version

Check out this piece of code taken from CodeProject.

bool son;

if (mShowShadow == false)
  son = false;
else
{
  if (DropShadowSupported() == false)
    son = false;
  else
  {
    son = true;
  }
}

if (son)
{
  parameters.ClassStyle += CS_DROPSHADOW;
}

The code doesn't made any sense to me, so I refactored and guess what the outcome:

if (mShowShadow && DropShadowSupported())
  parameters.ClassStyle += CS_DROPSHADOW;

Your rating: None Average: 4 (1 vote)